Skip to content
Snippets Groups Projects
Commit 560985b5 authored by Jason Short's avatar Jason Short
Browse files

made I term return in same pattern as D term

parent 75919436
No related branches found
No related tags found
No related merge requests found
......@@ -28,8 +28,9 @@ int32_t AC_PID::get_i(int32_t error, float dt)
} else if (_integrator > _imax) {
_integrator = _imax;
}
return _integrator;
}
return _integrator;
return 0;
}
int32_t AC_PID::get_d(int32_t input, float dt)
......@@ -73,8 +74,7 @@ int32_t AC_PID::get_pid(int32_t error, float dt)
// Compute derivative component if time has elapsed
if ((fabs(_kd) > 0) && (dt > 0)) {
_derivative = (error - _last_input) / dt;
_derivative = (error - _last_error) / dt;
// discrete low pass filter, cuts out the
// high frequency noise that can drive the controller crazy
......@@ -82,7 +82,7 @@ int32_t AC_PID::get_pid(int32_t error, float dt)
(dt / ( _filter + dt)) * (_derivative - _last_derivative);
// update state
_last_input = error;
_last_error = error;
_last_derivative = _derivative;
// add in derivative component
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment